epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
20,783 Commits 1 Branch 0 Tags
5d32b65a9c5d26f9cf60b3053e274616f2d9ee4a
Commit Graph

2583 Commits

Author SHA1 Message Date
reaperrr
bd2a24af55 Merge pull request #11223 from Mailaender/missile-dead 
Cleaned up logically dead Missile code.
 2016-05-08 14:09:27 +02:00
reaperrr
eb6157f81e Merge pull request #11197 from pchote/add-sysinfo-opt-out-prompt 
Add sysinfo opt out prompt
 2016-05-08 13:10:55 +02:00
Paul Chote
bd7e53bec4 Merge pull request #11234 from obrakmann/fix11218-spawnactorondeath-dispose-race 
Fix trait lookup of destroyed actor in SpawnActorOnDeath
 2016-05-07 15:58:20 +01:00
Matthias Mailänder
5462097c42 Merge pull request #11205 from reaperrr/rangelimit-wdist 
Refactored Missile.RangeLimit to be a WDist value
 2016-05-07 15:10:49 +02:00
Oliver Brakmann
35dfb54459 Fix trait lookup of destroyed actor in SpawnActorOnDeath 
The sequence of events leading to that crash looks like this:

1. Truk enters a building.

2. `Enter.FindAndTransitionToNextState()` is running, and since `DonateSupplies` uses `EnterBehaviour.Dispose`, `Actor.Dispose()` runs for the actor, queueing a FrameEndTask.

3. Truk is then killed:

 * `Health.InflictDamage()` first calls `SpawnActorOnDeath.Killed()`, which queues a FrameEndTask during which some trait lookups happen.

 * `Health.InflightDamage()` then calls `Actor.Dispose()` as well, queueing another FrameEndTask (which will never run, the game crashes before).

4. After the tick, the first FrameEndTask disposes of the actor. The second FrameEndTask would spawn the crate from the truk, but the trait lookups then fail and throw an exception.
 2016-05-07 14:21:41 +02:00
Paul Chote
cf4ef11403 Merge pull request #11232 from abcdefg30/navalRepair 
Fix possible instant repairs by spamming Repair activities
 2016-05-07 10:30:57 +01:00
abcdefg30
25b1c991a2 Fix possible instant repairs by spamming Repair activities 
Noticeable when spam-clicking on a naval yard/sub pen.
 2016-05-06 17:51:24 +02:00
HenrytheSlav
1962ea3abc Fixes Utility import facings mirror-flip 2016-05-05 18:44:23 +02:00
Matthias Mailänder
3d865d46e7 Removed logically dead code. 
targetPassedBy is always true in this section
and - times - is +.
 2016-05-05 10:19:38 +02:00
Matthias Mailänder
1bc4200128 Merge pull request #11136 from SzabKel/musicButtons 
Added music controlling hotkeys. Closes #3231
 2016-05-03 07:16:05 +02:00
Matthias Mailänder
891c5d9937 Merge pull request #11168 from reaperrr/hitshape-offsets 
Add support for custom vertical HitShape offsets
 2016-05-03 07:12:49 +02:00
abcdefg30
c3c29ee7a2 Make the circle and arrow sequences of Beacon optional 2016-05-02 17:23:17 +02:00
reaperrr
f6907cc42f Lint check for missile RangeLimit 2016-05-01 14:27:50 +02:00
reaperrr
249e65c7d1 RangeLimit WDist refactor upgrade rules 2016-05-01 14:27:49 +02:00
Matthias Mailänder
6a9b8e81f4 Don't expose palettes and sprites to Lua. 2016-05-01 12:29:39 +02:00
Matthias Mailänder
4e9a48d253 Summarize the rendering parts to generate a beacon. 2016-05-01 12:29:39 +02:00
Matthias Mailänder
a8dd67a231 ParatroopersPower also supports beacons. 2016-05-01 12:29:38 +02:00
Matthias Mailänder
59fbfbc851 Don't enforce beacons to be player palettes. 2016-05-01 12:29:38 +02:00
Matthias Mailänder
9f4cdb9843 Unhardcode player beacons for documentation and lint testing. 2016-05-01 12:27:02 +02:00
Matthias Mailänder
76124b7c79 Unhardcode beacon sprites for documentation and lint testing. 2016-05-01 12:21:13 +02:00
reaperrr
1258ddde7f Refactored Missile.RangeLimit from ticks to WDist 
Changed default from 'unlimited' fuel to weapon range.
 2016-04-30 16:02:15 +02:00
Oliver Brakmann
cc9f84f136 Merge pull request #11199 from reaperrr/fix-para-nre 
Fix potential NRE in Parachutable
 2016-04-30 13:53:04 +02:00
reaperrr
58ba25cc17 Merge pull request #10813 from Mailaender/vein-damage 
Added damaging through Veins.
 2016-04-29 13:28:58 +02:00
reaperrr
b87b2c010f Fix potential NRE in Parachutable 2016-04-29 12:56:05 +02:00
Paul Chote
21989acd28 Fix a crash when multi-turreted units leave a transport. 2016-04-29 04:05:33 +01:00
Paul Chote
25a1c0c283 Include version/mod/modversion in the game list query. 2016-04-27 23:06:21 +01:00
Paul Chote
98faa15d62 Add an opt-out prompt for system information collection. 2016-04-27 22:14:26 +01:00
reaperrr
72c580b708 Add top and bottom offsets to HitShapes 2016-04-24 20:47:56 +02:00
reaperrr
828dc61b67 Use already cached mobile in MobileProperties.Scatter 2016-04-24 20:12:51 +02:00
reaperrr
b497869993 Cache IMove in Repairable's ctor 
Instead of looking it up on every repair order.
 2016-04-24 20:12:49 +02:00
Paul Chote
59f5e24189 Simplify and fix missile turnaround facing check. 2016-04-23 17:14:56 +01:00
Matthias Mailänder
fb53890636 Merge pull request #11144 from pchote/fix-start-game-frozen-explored-map 
Generate frozen actor renderables for all map-placed actors.
 2016-04-23 16:26:27 +02:00
reaperrr
863772675b Merge pull request #11165 from pchote/fix-missile-flip 
Fix missile facing check.
 2016-04-23 15:15:59 +02:00
reaperrr
3dcb7bc02b Fix missiles not moving to CruiseAltitude if launched above it 2016-04-23 14:50:35 +02:00
Paul Chote
13cfd3699d Fix missile facing check. 2016-04-23 13:37:08 +01:00
Oliver Brakmann
3b2a5e2dbc Merge pull request #11162 from reaperrr/fix-11159 
Enable Targetable to handle multiple Cloak traits
 2016-04-22 22:15:06 +02:00
reaperrr
521a8a66d2 Enable Targetable to handle multiple Cloak traits 2016-04-22 13:01:02 +02:00
Oliver Brakmann
c8a9936b6c Merge pull request #11161 from pchote/fix-td-replay-timer 
Fix replay timer.
 2016-04-21 21:17:22 +02:00
Paul Chote
a8350783fc Fix game timer when adjusting replay speed. 2016-04-21 17:52:47 +01:00
Paul Chote
08100dc49b Fix initial render state for walls. 2016-04-21 17:21:29 +01:00
Paul Chote
183e5ae7ab Generate initial frozen renderables for all map-placed actors. 2016-04-21 17:21:29 +01:00
reaperrr
8bd8e8aa56 Merge pull request #11154 from obrakmann/fix11055_targetable-cloaked-units 
Fix looking up un-required trait in Targetable ctor
 2016-04-21 13:02:38 +02:00
reaperrr
65f8b9f63b Merge pull request #11141 from Mailaender/missile-targetedPassedBy 
Removed redundant targetPassedBy check.
 2016-04-21 12:30:14 +02:00
reaperrr
d82ff3412c Merge pull request #11137 from Mailaender/deadcode-healthradiuscheck 
Removed unnecessary null checks in CheckTargetHealthRadius
 2016-04-21 12:29:40 +02:00
Oliver Brakmann
eb2d7016b5 Merge pull request #11152 from abcdefg30/lobbyNote 
Fix reselecting a dropdown option in the lobby causing a server message
 2016-04-20 20:34:40 +02:00
Oliver Brakmann
357d50679c Fix looking up un-required trait in Targetable ctor 2016-04-19 22:39:36 +02:00
RoosterDragon
178fcfaf8c Use Contains method on Selection when possible. 
This allows the set to be utilized for a fast check, rather than degrading to a linear search via LINQ.
 2016-04-19 21:19:36 +01:00
abcdefg30
ea68fbdd7c Fix reselecting a dropdown option in the lobby causing a server message 2016-04-19 20:49:57 +02:00
Matthias Mailänder
133a0f54a3 Check for invalid targets to avoid crashing. 2016-04-18 08:46:04 +02:00
Paul Chote
c68ef3d25f Preserve editor actor order. 2016-04-17 20:25:20 -04:00