Files
OpenRA/OpenRA.Mods.Common
RoosterDragon 1fc1bdc849 Fix frozen actors lacking tooltips if they have the cloak ability.
Since bbf5970bc1 we update frozen actors only when required.

In 8339c6843e a regression was fixed where actors created in line of sight would be invisible.

Here, we fix a related regression where cloaked units that are revealed, and then frozen when you move out of line of sight would lack tooltips.

The fix centers around the setting of the Hidden flag. In the old code this used CanBeViewedByPlayer which checks for visibility modifiers and then uses the default visibility. The bug with this code is that when a visibility modifier was not hiding the actor, then we would report the default visibility state instead. However the frozen visibility state applies here which means if the frozen actor is visible, then we consider the actor to be hidden and therefore tooltips will not appear. In the fixed version we only consider the modifiers. This means a visibility modifier such as Cloak can hide the frozen actor tooltips. But otherwise we do not consider the frozen actor to be hidden. This prevents a frozen actor from hiding its own tooltips in some unintended circular logic. Hidden now becomes just a flag to indicate if the visibility modifiers are overriding things, as intended.
2022-08-31 23:31:48 +03:00
..
2022-05-28 00:35:10 -05:00
2022-05-28 00:35:10 -05:00
2022-08-30 20:03:40 +02:00
2022-08-14 16:11:51 +02:00
2022-05-28 00:35:10 -05:00
2022-08-31 16:04:40 +03:00
2022-05-28 00:35:10 -05:00
2022-05-28 00:35:10 -05:00
2022-05-28 00:35:10 -05:00
2022-05-28 00:35:10 -05:00
2022-05-28 00:35:10 -05:00