9cd55df584
Aligns the naming conventions defined in editorconfig (dotnet_naming_style, dotnet_naming_symbols, dotnet_naming_rule) which are reported under the IDE1006 rule with the existing StyleCop rules from the SA13XX range. This ensures the two rulesets agree when rejecting and accepting naming conventions within the IDE, with a few edges cases where only one ruleset can enforce the convention. IDE1006 allows use to specify a naming convention for type parameters, const locals and protected readonly fields which SA13XX cannot enforce. Some StyleCop SA13XX rules such as SA1309 'Field names should not begin with underscore' are not possible to enforce with the naming rules of IDE1006. Therefore we enable the IDE1006 as a build time warning to enforce conventions and extend them. We disable SA13XX rules that can now be covered by IDE1006 to avoid double-reporting but leave the remaining SA13XX rules that cover additional cases enabled. We also re-enable the SA1311 rule convention but enforce it via IDE1006, requiring some violations to be fixed or duplication of existing suppressions. Most violations fixes are trivial renames with the following exception. In ActorInitializer.cs, we prefer to make the fields private instead. ValueActorInit provides a publicly accessible property for access and OwnerInit provides a publicly accessible method. Health.cs is adjusted to access the property base instead when overriding. The reflection calls must be adjusted to target the base class specifically, as searching for a private field from the derived class will fail to locate it on the base class. Unused suppressions were removed.
90 lines
3.1 KiB
C#
90 lines
3.1 KiB
C#
#region Copyright & License Information
|
|
/*
|
|
* Copyright 2007-2021 The OpenRA Developers (see AUTHORS)
|
|
* This file is part of OpenRA, which is free software. It is made
|
|
* available to you under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation, either version 3 of
|
|
* the License, or (at your option) any later version. For more
|
|
* information, see COPYING.
|
|
*/
|
|
#endregion
|
|
|
|
using System;
|
|
using System.Diagnostics.CodeAnalysis;
|
|
using OpenRA.Primitives;
|
|
|
|
namespace OpenRA
|
|
{
|
|
[SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "Mimic a built-in type alias.")]
|
|
public readonly struct int2 : IEquatable<int2>
|
|
{
|
|
public readonly int X, Y;
|
|
public int2(int x, int y) { X = x; Y = y; }
|
|
public int2(Size p) { X = p.Width; Y = p.Height; }
|
|
|
|
public static int2 operator +(int2 a, int2 b) { return new int2(a.X + b.X, a.Y + b.Y); }
|
|
public static int2 operator +(int2 a, Size b) { return new int2(a.X + b.Width, a.Y + b.Height); }
|
|
public static int2 operator -(int2 a, int2 b) { return new int2(a.X - b.X, a.Y - b.Y); }
|
|
public static int2 operator *(int a, int2 b) { return new int2(a * b.X, a * b.Y); }
|
|
public static int2 operator *(int2 b, int a) { return new int2(a * b.X, a * b.Y); }
|
|
public static int2 operator /(int2 a, int b) { return new int2(a.X / b, a.Y / b); }
|
|
|
|
public static int2 operator -(int2 a) { return new int2(-a.X, -a.Y); }
|
|
|
|
public static bool operator ==(int2 me, int2 other) { return me.X == other.X && me.Y == other.Y; }
|
|
public static bool operator !=(int2 me, int2 other) { return !(me == other); }
|
|
|
|
public override int GetHashCode() { return X.GetHashCode() ^ Y.GetHashCode(); }
|
|
|
|
public bool Equals(int2 other) { return this == other; }
|
|
public override bool Equals(object obj) { return obj is int2 && Equals((int2)obj); }
|
|
|
|
public override string ToString() { return X + "," + Y; }
|
|
|
|
public int2 Sign() { return new int2(Math.Sign(X), Math.Sign(Y)); }
|
|
public int2 Abs() { return new int2(Math.Abs(X), Math.Abs(Y)); }
|
|
public int LengthSquared => X * X + Y * Y;
|
|
public int Length => Exts.ISqrt(LengthSquared);
|
|
|
|
public int2 WithX(int newX)
|
|
{
|
|
return new int2(newX, Y);
|
|
}
|
|
|
|
public int2 WithY(int newY)
|
|
{
|
|
return new int2(X, newY);
|
|
}
|
|
|
|
public static int2 Max(int2 a, int2 b) { return new int2(Math.Max(a.X, b.X), Math.Max(a.Y, b.Y)); }
|
|
public static int2 Min(int2 a, int2 b) { return new int2(Math.Min(a.X, b.X), Math.Min(a.Y, b.Y)); }
|
|
|
|
public static readonly int2 Zero = new int2(0, 0);
|
|
public float2 ToFloat2() { return new float2(X, Y); }
|
|
|
|
// Change endianness of a uint32
|
|
public static uint Swap(uint orig)
|
|
{
|
|
return ((orig & 0xff000000) >> 24) | ((orig & 0x00ff0000) >> 8) | ((orig & 0x0000ff00) << 8) | ((orig & 0x000000ff) << 24);
|
|
}
|
|
|
|
public static int Lerp(int a, int b, int mul, int div)
|
|
{
|
|
return a + (b - a) * mul / div;
|
|
}
|
|
|
|
public static int2 Lerp(int2 a, int2 b, int mul, int div)
|
|
{
|
|
return a + (b - a) * mul / div;
|
|
}
|
|
|
|
public int2 Clamp(Rectangle r)
|
|
{
|
|
return new int2(Math.Min(r.Right, Math.Max(X, r.Left)),
|
|
Math.Min(r.Bottom, Math.Max(Y, r.Top)));
|
|
}
|
|
|
|
public static int Dot(int2 a, int2 b) { return a.X * b.X + a.Y * b.Y; }
|
|
}
|
|
}
|