a9339d91ea
The bug happens when a second (or third, fourth etc.) Conyard deploys while a building is placed from the first Conyard. The `WithMakeAnimation` running on the second CY uses `Animation::PlayThen` to call `Building::Unlock` in a delegate. `WithBuildingPlacedAnimation::BuildingPlaced` runs when a building placed and replaces the delegate from `WithMakeAnimation` with its own before it has a chance to run, and so the new Conyard never gets unlocked. The fix is then to simply not run `BuildingPlaced` on conyards that haven't completed the make animation yet.
48 lines
1.3 KiB
C#
48 lines
1.3 KiB
C#
#region Copyright & License Information
|
|
/*
|
|
* Copyright 2007-2015 The OpenRA Developers (see AUTHORS)
|
|
* This file is part of OpenRA, which is free software. It is made
|
|
* available to you under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation. For more information,
|
|
* see COPYING.
|
|
*/
|
|
#endregion
|
|
|
|
using OpenRA.Traits;
|
|
|
|
namespace OpenRA.Mods.Common.Traits
|
|
{
|
|
[Desc("Changes the animation when the actor constructed a building.")]
|
|
public class WithBuildingPlacedAnimationInfo : ITraitInfo, Requires<RenderSimpleInfo>
|
|
{
|
|
[Desc("Sequence name to use")]
|
|
public readonly string Sequence = "build";
|
|
|
|
public object Create(ActorInitializer init) { return new WithBuildingPlacedAnimation(init.Self, this); }
|
|
}
|
|
|
|
public class WithBuildingPlacedAnimation : INotifyBuildingPlaced, INotifyBuildComplete
|
|
{
|
|
WithBuildingPlacedAnimationInfo info;
|
|
RenderSimple renderSimple;
|
|
bool buildComplete;
|
|
|
|
public WithBuildingPlacedAnimation(Actor self, WithBuildingPlacedAnimationInfo info)
|
|
{
|
|
this.info = info;
|
|
renderSimple = self.Trait<RenderSimple>();
|
|
buildComplete = !self.HasTrait<Building>();
|
|
}
|
|
|
|
public void BuildingComplete(Actor self)
|
|
{
|
|
buildComplete = true;
|
|
}
|
|
|
|
public void BuildingPlaced(Actor self)
|
|
{
|
|
if (buildComplete)
|
|
renderSimple.PlayCustomAnim(self, info.Sequence);
|
|
}
|
|
}
|
|
} |