corrected some grammatical errors in the readme (#564)

This commit is contained in:
RISHABH YADAV
2023-01-14 17:34:16 +05:30
committed by GitHub
parent 42f7f8cc29
commit 0823e1374d

View File

@@ -26,7 +26,7 @@ docker run hello-world
# the daemon won't load it automatically
sudo modprobe xt_ipvs
# Ensure Docker daemon is running in swarm mode
# Ensure the Docker daemon is running in swarm mode
docker swarm init
# Get the latest franela/dind image
@@ -47,13 +47,13 @@ to create a new session, followed by "ADD NEW INSTANCE" to launch a new terminal
Notes:
* There is a hard-coded limit to 5 Docker playgrounds per session. After 4 hours sessions are deleted.
* There is a hard-coded limit of 5 Docker playgrounds per session. After 4 hours sessions are deleted.
* If you want to override the DIND version or image then set the environmental variable i.e.
`DIND_IMAGE=franela/docker<version>-rc:dind`. Take into account that you can't use standard `dind` images, only [franela](https://hub.docker.com/r/franela/) ones work.
### Port forwarding
In order for port forwarding to work correctly in development you need to make `*.localhost` to resolve to `127.0.0.1`. That way when you try to access to `pwd10-0-0-1-8080.host1.localhost`, then you're forwarded correctly to your local PWD server.
In order for port forwarding to work correctly in development you need to make `*.localhost` to resolve to `127.0.0.1`. That way when you try to access `pwd10-0-0-1-8080.host1.localhost`, then you're forwarded correctly to your local PWD server.
You can achieve this by setting up a `dnsmasq` server (you can run it in a docker container also) and adding the following configuration:
@@ -61,7 +61,7 @@ You can achieve this by setting up a `dnsmasq` server (you can run it in a docke
address=/localhost/127.0.0.1
```
Don't forget to change your computer default DNS to use the dnsmasq server to resolve.
Don't forget to change your computer's default DNS to use the dnsmasq server to resolve.
## FAQ
@@ -70,7 +70,7 @@ Don't forget to change your computer default DNS to use the dnsmasq server to re
If you need to access your services from outside, use the following URL pattern `http://ip<hyphen-ip>-<session_jd>-<port>.direct.labs.play-with-docker.com` (i.e: http://ip-2-135-3-b8ir6vbg5vr00095iil0-8080.direct.labs.play-with-docker.com).
### Why is PWD running in ports 80 and 443?, Can I change that?.
### Why is PWD running in ports 80 and 443? Can I change that?
No, it needs to run on those ports for DNS resolve to work. Ideas or suggestions about how to improve this
are welcome