epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant ISync and ITick from Attack* traits

Browse Source 
ISync is implemented by AttackBase, so there's no need for other Attack traits to implement it again.
AttackTurreted inherits AttackFollow, which already implements ITick.
This commit is contained in:
reaperrr
2015-07-29 17:45:30 +02:00
parent c660d32051
commit 398f02c5db
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
OpenRA.Mods.Common/Traits/Attack/AttackCharge.cs
View File

@@ -35,7 +35,7 @@ namespace OpenRA.Mods.Common.Traits
public override object Create(ActorInitializer init) { return new AttackCharge(init.Self, this); } public override object Create(ActorInitializer init) { return new AttackCharge(init.Self, this); }
} }
class AttackCharge : AttackOmni, ITick, INotifyAttack, ISync class AttackCharge : AttackOmni, ITick, INotifyAttack
{ {
readonly AttackChargeInfo info; readonly AttackChargeInfo info;

2
OpenRA.Mods.Common/Traits/Attack/AttackFollow.cs
View File

@@ -20,7 +20,7 @@ namespace OpenRA.Mods.Common.Traits
public override object Create(ActorInitializer init) { return new AttackFollow(init.Self, this); } public override object Create(ActorInitializer init) { return new AttackFollow(init.Self, this); }
} }
public class AttackFollow : AttackBase, ITick, INotifyOwnerChanged, ISync public class AttackFollow : AttackBase, ITick, INotifyOwnerChanged
{ {
public Target Target { get; protected set; } public Target Target { get; protected set; }

2
OpenRA.Mods.Common/Traits/Attack/AttackOmni.cs
View File

@@ -18,7 +18,7 @@ namespace OpenRA.Mods.Common.Traits
public override object Create(ActorInitializer init) { return new AttackOmni(init.Self, this); } public override object Create(ActorInitializer init) { return new AttackOmni(init.Self, this); }
} }
class AttackOmni : AttackBase, ISync class AttackOmni : AttackBase
{ {
public AttackOmni(Actor self, AttackOmniInfo info) public AttackOmni(Actor self, AttackOmniInfo info)
: base(self, info) { } : base(self, info) { }

2
OpenRA.Mods.Common/Traits/Attack/AttackTurreted.cs
View File

@@ -21,7 +21,7 @@ namespace OpenRA.Mods.Common.Traits
public override object Create(ActorInitializer init) { return new AttackTurreted(init.Self, this); } public override object Create(ActorInitializer init) { return new AttackTurreted(init.Self, this); }
} }
public class AttackTurreted : AttackFollow, ITick, ISync public class AttackTurreted : AttackFollow
{ {
protected Turreted[] turrets; protected Turreted[] turrets;