Merge pull request #10023 from OpenRA/fixGpsDot

Fix gps dot

OpenRA.Game/Player.cs

@@ -159,13 +159,13 @@ namespace OpenRA
 
 		public bool CanTargetActor(Actor a)
 		{
-			if (HasFogVisibility)
+			if (HasFogVisibility && fogVisibilities.Any(f => f.IsVisible(a)))
 				return true;
 
 			return CanViewActor(a);
 		}
 
-		public bool HasFogVisibility { get { return fogVisibilities.Any(f => f.HasFogVisibility(this)); } }
+		public bool HasFogVisibility { get { return fogVisibilities.Any(f => f.HasFogVisibility()); } }
 
 		#region Scripting interface
 

OpenRA.Game/Traits/TraitsInterfaces.cs

@@ -189,7 +189,12 @@ namespace OpenRA.Traits
 	public interface IDefaultVisibilityInfo : ITraitInfo { }
 	public interface IDefaultVisibility { bool IsVisible(Actor self, Player byPlayer); }
 	public interface IVisibilityModifier { bool IsVisible(Actor self, Player byPlayer); }
-	public interface IFogVisibilityModifier { bool HasFogVisibility(Player byPlayer); }
+
+	public interface IFogVisibilityModifier
+	{
+		bool IsVisible(Actor actor);
+		bool HasFogVisibility();
+	}
 
 	public interface IRadarColorModifier { Color RadarColorOverride(Actor self); }
 

OpenRA.Mods.RA/Effects/GpsDot.cs

@@ -10,6 +10,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using OpenRA.Effects;
 using OpenRA.Graphics;
 using OpenRA.Mods.Common.Traits;
@@ -36,6 +37,8 @@ namespace OpenRA.Mods.RA.Effects
 		readonly GpsDotInfo info;
 		readonly Animation anim;
 
+		readonly Dictionary<Player, bool> showToPlayer = new Dictionary<Player, bool>();
+
 		Lazy<HiddenUnderFog> huf;
 		Lazy<FrozenUnderFog> fuf;
 		Lazy<Disguise> disguise;
@@ -43,8 +46,6 @@ namespace OpenRA.Mods.RA.Effects
 		Cache<Player, GpsWatcher> watcher;
 		Cache<Player, FrozenActorLayer> frozen;
 
-		bool show = false;
-
 		public GpsDot(Actor self, GpsDotInfo info)
 		{
 			this.self = self;
@@ -61,9 +62,16 @@ namespace OpenRA.Mods.RA.Effects
 
 			watcher = new Cache<Player, GpsWatcher>(p => p.PlayerActor.Trait<GpsWatcher>());
 			frozen = new Cache<Player, FrozenActorLayer>(p => p.PlayerActor.Trait<FrozenActorLayer>());
+
+			showToPlayer = self.World.Players.ToDictionary(x => x, x => false);
 		}
 
-		bool ShouldShowIndicator()
+		public bool IsDotVisible(Player toPlayer)
+		{
+			return showToPlayer[toPlayer];
+		}
+
+		bool ShouldShowIndicator(Player toPlayer)
 		{
 			if (cloak.Value != null && cloak.Value.Cloaked)
 				return false;
@@ -71,20 +79,21 @@ namespace OpenRA.Mods.RA.Effects
 			if (disguise.Value != null && disguise.Value.Disguised)
 				return false;
 
-			if (huf.Value != null && !huf.Value.IsVisible(self, self.World.RenderPlayer))
+			if (huf.Value != null && !huf.Value.IsVisible(self, toPlayer)
+				&& toPlayer.Shroud.IsExplored(self.CenterPosition))
 				return true;
 
 			if (fuf.Value == null)
 				return false;
 
-			var f = frozen[self.World.RenderPlayer].FromID(self.ActorID);
+			var f = frozen[toPlayer].FromID(self.ActorID);
 			if (f == null)
 				return false;
 
 			if (f.HasRenderables || f.NeedRenderables)
 				return false;
 
-			return f.Visible;
+			return f.Visible && !f.Shrouded;
 		}
 
 		public void Tick(World world)
@@ -92,17 +101,19 @@ namespace OpenRA.Mods.RA.Effects
 			if (self.Disposed)
 				world.AddFrameEndTask(w => w.Remove(this));
 
-			show = false;
+			if (!self.IsInWorld || self.IsDead)
-			if (!self.IsInWorld || self.IsDead || self.World.RenderPlayer == null)
 				return;
 
-			var gps = watcher[self.World.RenderPlayer];
+			foreach (var player in self.World.Players)
-			show = (gps.Granted || gps.GrantedAllies) && ShouldShowIndicator();
+			{
+				var gps = watcher[player];
+				showToPlayer[player] = (gps.Granted || gps.GrantedAllies) && ShouldShowIndicator(player);
+			}
 		}
 
 		public IEnumerable<IRenderable> Render(WorldRenderer wr)
 		{
-			if (!show || self.Disposed)
+			if (self.World.RenderPlayer == null || !showToPlayer[self.World.RenderPlayer] || self.Disposed)
 				return SpriteRenderable.None;
 
 			var palette = wr.Palette(info.IndicatorPalettePrefix + self.Owner.InternalName);

OpenRA.Mods.RA/Traits/SupportPowers/GpsPower.cs

@@ -76,10 +76,19 @@ namespace OpenRA.Mods.RA.Traits
 				Owner.Shroud.ExploreAll(Owner.World);
 		}
 
-		public bool HasFogVisibility(Player byPlayer)
+		public bool HasFogVisibility()
 		{
 			return Granted || GrantedAllies;
 		}
+
+		public bool IsVisible(Actor actor)
+		{
+			var gpsDot = actor.TraitOrDefault<GpsDot>();
+			if (gpsDot == null)
+				return false;
+
+			return gpsDot.IsDotVisible(Owner);
+		}
 	}
 
 	class GpsPowerInfo : SupportPowerInfo