Commit Graph

18 Commits

Author SHA1 Message Date
Matthias Mailänder
50e5e9df24 check voice actor references 2015-06-20 12:09:58 +02:00
Matthias Mailänder
264a63e58c move GetFieldValues to shared LintExts 2015-06-20 10:47:28 +02:00
Paul Chote
6762e033e2 Add lint rule. 2015-06-19 22:02:07 +01:00
Matthias Mailänder
e2e9ce9d7e check sequence image at RenderSprites level 2015-06-11 21:18:25 +02:00
Pavel Penev
53f26adb88 Merge pull request #8309 from Mailaender/lint-neutral
Added a lint rule to check if Neutral is set up correctly
2015-06-01 02:06:06 +03:00
Matthias Mailänder
98afa922ac Random is already in the race list 2015-05-31 20:33:29 +02:00
Matthias Mailänder
44691831ad check for invalid owners 2015-05-31 18:33:23 +02:00
Matthias Mailänder
3167ca48ff check if the neutral player is set up correctly 2015-05-31 09:44:50 +02:00
Matthias Mailänder
7186f654d7 avoid an unneeded loop 2015-05-31 09:43:35 +02:00
penev92
6b4bf10227 Add lint rule for Death Types 2015-05-29 23:41:56 +03:00
Matthias Mailänder
a943fbc94e check for duplicate spawn point locations 2015-05-13 15:28:19 +02:00
Matthias Mailänder
bb08537c44 check for too few/many spawn points/player definitions 2015-05-13 15:27:11 +02:00
penev92
dc3ae39db1 Rename ProvidesCustomPrerequisite to ProvidesPrerequisite 2015-05-07 03:04:11 +03:00
penev92
50fb6f1d25 Make buildings grant prerequisites explicitly 2015-05-04 01:39:32 +03:00
Paul Chote
4b1f541f34 Reorganize actor and smudge loading.
The actor and smudge definitions are now stored
as raw MiniYamlNodes in the map.  It is now the
responsibility of the consumers to parse these
into real objects.
2015-04-30 07:06:14 +12:00
penev92
2402b56da7 Reorganize PlayerReference loading to enable upgrade rules for them.
The PlayerReference definitions are now stored
as raw MiniYamlNodes in the map.
2015-04-26 23:16:20 +03:00
RoosterDragon
82bea961ba Checked LINQ queries and collections for inefficiencies.
- Made Array.IndexOf available via extension method.
- Made ToHashSet extension method.
- Change collections queried often via Contains into sets.
- Avoid Count() extension if Count or Length property exist.
- Made Count() > 0 checks and variations calls to Any() instead.
- Don't call ToList/ToArray if there is no benefit to materializing the sequence.
- If the sequence does benefit from materialization, follow this general pattern:
  - Collection queried often via Contains use ToHashSet to speed up lookups.
  - Short lived variables use ToList. This is because ToArray requires an extra copy to output the final size.
  - Collections persisted into fields or for a long time use ToArray to minimize memory overhead.
2015-01-29 19:20:11 +00:00
reaperrr
52dd8c922f Moves Lint checks to Mods.Common 2015-01-15 23:15:51 +01:00