Commit Graph

120 Commits

Author SHA1 Message Date
RoosterDragon
c8c7629bce Convert some stray spaces to tabs. 2017-12-16 15:53:03 +00:00
Paul Chote
55b6084b60 Add a lint test for conflicting Interactable and Selectable. 2017-12-11 19:45:07 +01:00
RoosterDragon
5338784e45 Fix bad uses of FirstEnabledTraitOrDefault on TraitInfos.
These are not traits so this method does not work. We can use EnabledByDefault on the ConditionalTraitInfo instead.
2017-12-10 13:39:24 +00:00
RoosterDragon
7a7eed4fb7 Add FirstEnabledTraitOrDefault helper method.
This avoids the allocations caused by LINQ when using traits.FirstOrDefault(Exts.IsTraitEnabled). This is important in FrozenActorLayer.RefreshState which is called very often. We apply the new helper method to all areas using the old pattern. An overload that takes an array allows arrays to be enumerated without causing allocations.
2017-12-10 13:39:24 +00:00
Paul Chote
b4c5346346 Migrate hotkey linter to HotkeyManager. 2017-12-08 01:29:15 +01:00
Paul Chote
c4237d6a1a Rename NamedHotkey to HotkeyReference. 2017-12-08 01:29:15 +01:00
Paul Chote
19000219af Allow widgets to expose custom hotkey names to the linter. 2017-09-10 21:30:55 +02:00
Paul Chote
8d4ffee32a Add hotkey linting support for logic args. 2017-08-31 12:33:34 +02:00
Paul Chote
a29360f313 Add a lint test for hotkeys. 2017-08-25 21:56:52 +02:00
reaperrr
46dc827d46 Refactor footprint cell lookups and move them to Building
Removing FootprintUtils happens in the next commit for better
reviewability.
2017-07-13 17:43:41 +02:00
abcdefg30
118039ded3 Add a missing i 2017-06-22 14:35:26 +02:00
abcdefg30
839945cf57 Fix a crash in CheckSequences when the sprite image is null 2017-06-22 14:35:26 +02:00
reaperrr
7fd0a3aa58 Lint check and yaml enforcement for HitShape
Now that Health no longer provides a HitShape, actors with Health need at
least one HitShape trait.
2017-06-04 00:07:08 +02:00
abcdefg30
434ea9ca88 Throw a lint error or an exception when no player owns the world 2017-05-20 11:02:00 +02:00
reaperrr
5b8c313d55 Remove lint rule for victim scan radii
They're now calculated automatically to use the most sensible value by default. Only people who know what they're doing or fool around will use custom values, and in that case a lint rule might actually just annoy people.
2017-05-13 11:15:38 -07:00
atlimit8
b0187dd646 Added (Boolean|Integer)Expression subclasses of VariableExpression 2017-04-11 02:52:54 -05:00
atlimit8
e73d3922dd Rename ConditionExpression => VariableExpression 2017-04-11 01:26:38 -05:00
atlimit8
d83dae5587 Rename BooleanExpression => ConditionExpression 2017-02-22 08:54:50 -06:00
Paul Chote
85630501e1 Work around lint test limitations. 2017-01-29 18:58:35 +00:00
Taryn Hill
43317e0f5d Update copyright notice year to 2017 2016-12-31 23:46:13 -06:00
Paul Chote
d0270ab866 Rename comments and documentation. 2016-12-23 15:17:02 +00:00
Paul Chote
dcad5c3f7c Rename UpgradeManager to ConditionManager. 2016-12-23 14:57:56 +00:00
Paul Chote
f787f275db Add actor conditions lint rule. 2016-12-23 11:31:06 +00:00
reaperrr
848cf19ba8 Merge pull request #12381 from pchote/upgrade-conditions
Upgrades overhaul part 1: EnabledCondition
2016-11-30 19:42:34 +01:00
Paul Chote
b1f99dd601 Add GroundPosition VisibilityType. 2016-11-26 21:10:44 +00:00
Paul Chote
ef8a7a535d Fix string comparison in CheckRevealFootprint. 2016-11-26 21:10:28 +00:00
Paul Chote
0ba0470390 Remove upgrades lint check. 2016-11-20 13:55:47 +00:00
Paul Chote
1cc7944437 Add FieldLoader and linter support for BooleanExpression. 2016-11-19 17:19:25 +00:00
Paul Chote
c62870cc30 Merge pull request #12004 from reaperrr/projectile-cleanup2
More projectile property streamlining and cleanups
2016-10-29 14:21:29 +01:00
reaperrr
00c0161513 Show internal name instead of crashing when buildable actor has no tooltip
But throw a lint error instead.
2016-10-23 14:59:22 +02:00
reaperrr
efd54f1c65 Add lint check for invalid projectile angles
Emits error if
- angle exceeds 255 or -255
- minimum launch angle exceeds maximum launch angle
2016-10-22 18:00:36 +02:00
Guido Lipke
ab8c35123b [Lint] Report when Maps contains invalid custom rules.
Report when Maps contains invalid custom rules.
2016-10-04 14:39:21 +02:00
reaperrr
239f51e8b2 Merge pull request #11406 from Mailaender/upgrademanager-exception
Added an error message when setting up upgrades without UpgradeManager
2016-06-11 12:59:59 +02:00
Matthias Mailänder
3b27975b33 Also check for a missing UpgradeManager trait
as optional upgrades will otherwise be silently non-functional.
2016-06-05 17:37:36 +02:00
Matthias Mailänder
bec879cf7c Don't check modulare actor templates
as the inherited combinations of the actors are of concern.
2016-06-05 17:36:32 +02:00
Matthias Mailänder
6cc7a21629 Add FLAMEGUY. 2016-06-05 00:35:42 +02:00
Paul Chote
b4d1517d0d Set yaml filename when loading from FileSystem. 2016-06-04 15:23:44 +01:00
Oliver Brakmann
916f2ea2ea Merge pull request #11382 from reaperrr/projectile-streamlining
Moved projectiles to their own namespace and streamlined property names
2016-06-04 15:00:08 +02:00
Matthias Mailänder
13cf193640 Lint check for invalid building footprint definitions. 2016-05-28 16:03:19 +02:00
reaperrr
fef4f3eb79 Move projectiles to their own namespace and folder
While they are (currently) technically effects, this makes the actual purpose and wiki more clear.
2016-05-28 14:42:33 +02:00
Oliver Brakmann
8d3320c0e3 Add a lint check to ensure mpspawns are owned by the world owner 2016-05-22 12:55:35 +02:00
Oliver Brakmann
b4664d1ec5 Merge pull request #11192 from reaperrr/fix-effectwh
Fix direct hit check in CreateEffectWarhead
2016-05-18 21:52:30 +02:00
reaperrr
f6907cc42f Lint check for missile RangeLimit 2016-05-01 14:27:50 +02:00
reaperrr
10dc6ca85c CreateEffectWarhead.TargetSearchRadius lint check 2016-04-26 19:47:22 +02:00
reaperrr
d82ff3412c Merge pull request #11137 from Mailaender/deadcode-healthradiuscheck
Removed unnecessary null checks in CheckTargetHealthRadius
2016-04-21 12:29:40 +02:00
Matthias Mailänder
12543f2f32 Avoid logically dead code. 2016-04-17 16:00:57 +02:00
reaperrr
fd5a597966 Move Render traits to Traits.Render namespace 2016-04-15 20:43:04 +02:00
Paul Chote
96eda08677 Replace map type with a category list. 2016-03-27 12:16:55 +01:00
Paul Chote
4a7ef68b39 Remove Map.SpawnPoints. 2016-03-18 20:16:25 +00:00
Paul Chote
a3b1baa654 Extract default TileSet/Sequence dictionaries to ModData. 2016-03-11 21:18:32 +00:00