Commit Graph

49 Commits

Author SHA1 Message Date
RoosterDragon
1b1e4f1dd2 Merge pull request #9174 from reaperrr/radius-explode
Customizable impact victim scan radius
2015-09-30 20:28:17 +01:00
Matthias Mailänder
defba7aece lint check player palette reference
and tell which actor is affected when a problem is found
2015-09-27 14:57:58 +02:00
reaperrr
4c41f8f656 Lint check for SpreadDamageWarhead victim scan radius bonus 2015-09-26 17:46:28 +02:00
Pavel Penev
cdd4590ece Merge pull request #8839 from RoosterDragon/test-sync-implementations
Test sync implementations
2015-09-24 15:17:33 +03:00
RoosterDragon
3a63a427e6 Improved sync lint pass.
Now also checks for classes with Sync members lacking the ISync interface.
2015-09-21 22:17:09 +01:00
atlimit8
9acf121eb1 Replace ActorInfo.Traits.WithInterface with ActorInfo.TraitInfos<T>() 2015-09-21 15:50:57 -05:00
atlimit8
b38b6eadd0 Add IEnumerable<ITraitInfo> ActorInfo.TraitInfos() replacing actorInfo.traits enumeration 2015-09-21 15:50:57 -05:00
atlimit8
09984683a7 Add ActorInfo.TraitInfo[OrDefault]<T>() requiring ITraitIfo types 2015-09-19 09:56:14 -05:00
atlimit8
8162fa27ab Add ActorInfo.HasTraitInfo<T>() requiring ITraitInfo types 2015-09-19 09:49:24 -05:00
atlimit8
8250f223c4 More HashSet trait fields & Lint support 2015-09-05 16:59:30 -05:00
RoosterDragon
901e604cf3 Replace arrays with sets.
In places where arrays were being treated as a set, just create a set directly. This reveals the intention of such collections better, and also improves performance by allowing set based methods to be used.
2015-09-03 20:09:24 +01:00
Matthias Mailänder
0b8d7708ef add more lint interfaces to reduce boiler plate 2015-08-30 13:12:25 +02:00
Matthias Mailänder
5fc8a413e6 emitError for undefined sequences 2015-08-29 08:18:52 +02:00
Pavel Penev
09f67d18bb Some internal "race" to "faction" renaming 2015-08-22 23:34:36 +03:00
Matthias Mailänder
118782a85e check palette references 2015-08-17 21:36:45 +02:00
Matthias Mailänder
c5b1e6be5f fix a null reference exception at map (tileset) 2015-08-13 20:28:52 +02:00
Matthias Mailänder
fb22c9a1e5 test unchanged miniyaml rules only once 2015-08-04 14:20:52 +02:00
Matthias Mailänder
1f69a0f6ed make projectile sprite sequences lint testable 2015-07-19 19:24:18 +02:00
Oliver Brakmann
380cf22477 Merge pull request #8661 from penev92/bleed_renameCountry
Rename the Country trait to Faction
2015-07-14 21:05:52 +02:00
Oliver Brakmann
4ed7a4ce8a Merge pull request #8659 from penev92/bleed_playerReference
Rename PlayerReference.Race to Faction
2015-07-14 20:15:56 +02:00
penev92
0e871a4b6b Touch up CheckSequences.cs 2015-07-14 18:50:46 +03:00
penev92
830b7eee70 Touch up CheckPlayers.cs 2015-07-14 18:50:44 +03:00
penev92
2e04fb5ddd Rename Faction trait members
Rename Faction.Race to Faction.InternalName
2015-07-14 18:50:39 +03:00
penev92
a1af5386e0 Rename the Country trait to Faction 2015-07-14 18:50:31 +03:00
penev92
c3fcd9a8a1 Some cleanups 2015-07-06 22:24:50 +03:00
penev92
1d49c23af0 Rename PlayerReference.Race and LockRace to Faction and LockFaction 2015-07-05 23:08:49 +03:00
Paul Chote
7d62ac2b12 Merge RulesetCache.LoadDefaultRules and LoadMapRules. 2015-07-05 14:58:00 +01:00
Paul Chote
e87e8ae632 Add a lint rule for VisibilityType. 2015-07-04 17:07:08 +01:00
penev92
696680bad5 Add lint check for actor upgrades 2015-06-21 11:12:15 +03:00
Matthias Mailänder
7bb95a1658 Add LintExt and move GetFieldValues() 2015-06-21 11:06:53 +03:00
Matthias Mailänder
7faebe874a check for missing sequence entries using lint 2015-06-20 22:22:59 +02:00
Matthias Mailänder
50e5e9df24 check voice actor references 2015-06-20 12:09:58 +02:00
Matthias Mailänder
264a63e58c move GetFieldValues to shared LintExts 2015-06-20 10:47:28 +02:00
Paul Chote
6762e033e2 Add lint rule. 2015-06-19 22:02:07 +01:00
Matthias Mailänder
e2e9ce9d7e check sequence image at RenderSprites level 2015-06-11 21:18:25 +02:00
Pavel Penev
53f26adb88 Merge pull request #8309 from Mailaender/lint-neutral
Added a lint rule to check if Neutral is set up correctly
2015-06-01 02:06:06 +03:00
Matthias Mailänder
98afa922ac Random is already in the race list 2015-05-31 20:33:29 +02:00
Matthias Mailänder
44691831ad check for invalid owners 2015-05-31 18:33:23 +02:00
Matthias Mailänder
3167ca48ff check if the neutral player is set up correctly 2015-05-31 09:44:50 +02:00
Matthias Mailänder
7186f654d7 avoid an unneeded loop 2015-05-31 09:43:35 +02:00
penev92
6b4bf10227 Add lint rule for Death Types 2015-05-29 23:41:56 +03:00
Matthias Mailänder
a943fbc94e check for duplicate spawn point locations 2015-05-13 15:28:19 +02:00
Matthias Mailänder
bb08537c44 check for too few/many spawn points/player definitions 2015-05-13 15:27:11 +02:00
penev92
dc3ae39db1 Rename ProvidesCustomPrerequisite to ProvidesPrerequisite 2015-05-07 03:04:11 +03:00
penev92
50fb6f1d25 Make buildings grant prerequisites explicitly 2015-05-04 01:39:32 +03:00
Paul Chote
4b1f541f34 Reorganize actor and smudge loading.
The actor and smudge definitions are now stored
as raw MiniYamlNodes in the map.  It is now the
responsibility of the consumers to parse these
into real objects.
2015-04-30 07:06:14 +12:00
penev92
2402b56da7 Reorganize PlayerReference loading to enable upgrade rules for them.
The PlayerReference definitions are now stored
as raw MiniYamlNodes in the map.
2015-04-26 23:16:20 +03:00
RoosterDragon
82bea961ba Checked LINQ queries and collections for inefficiencies.
- Made Array.IndexOf available via extension method.
- Made ToHashSet extension method.
- Change collections queried often via Contains into sets.
- Avoid Count() extension if Count or Length property exist.
- Made Count() > 0 checks and variations calls to Any() instead.
- Don't call ToList/ToArray if there is no benefit to materializing the sequence.
- If the sequence does benefit from materialization, follow this general pattern:
  - Collection queried often via Contains use ToHashSet to speed up lookups.
  - Short lived variables use ToList. This is because ToArray requires an extra copy to output the final size.
  - Collections persisted into fields or for a long time use ToArray to minimize memory overhead.
2015-01-29 19:20:11 +00:00
reaperrr
52dd8c922f Moves Lint checks to Mods.Common 2015-01-15 23:15:51 +01:00