Commit Graph

26143 Commits

Author SHA1 Message Date
Paul Chote
c89f8dbb89 Enable StyleCop rule SA1002. 2019-06-08 18:46:03 +02:00
Paul Chote
65856f3b0e Fix remaining semicolon spacing issues. 2019-06-08 18:46:03 +02:00
Paul Chote
c253aaeb9d Replace for(;;) with while (true). 2019-06-08 18:46:03 +02:00
Paul Chote
4d8aaeb690 Enable StyleCop rule SA1128. 2019-06-08 18:44:50 +02:00
Paul Chote
674155a8dd Move ctor initializers to their own line. 2019-06-08 18:44:50 +02:00
reaperrr
979ed1b140 Merge HeliAttack into FlyAttack
And polish CanHover FlyAttack behavior:

- Get rid of direct TickFacing usage
- Fix that the CanHover facing/altitude update would override
  TakeOff child of Fly
- Streamline the queueing of child activities
- Get rid of a direct FlyTick in favor of relying on Fly activity
- Pull queueing of TakeOff out of the if-else
2019-06-08 17:07:18 +01:00
Paul Chote
a7617b2443 Reseed the RNG when restarting a game. 2019-06-08 16:23:33 +02:00
abcdefg30
586fa80943 Defer running the contents of TraitEnabled in WithMoveAnimation 2019-06-08 15:28:54 +02:00
Paul Chote
1aa80f9c11 Add download hashes for the default mod packages. 2019-06-08 13:39:17 +02:00
Paul Chote
03c1eaad76 Add a SHA1 check for downloaded packages. 2019-06-08 13:39:17 +02:00
Paul Chote
1d3754f9c0 Enable StyleCop rules SA1509, SA1513. 2019-06-08 13:20:14 +02:00
Paul Chote
548de12e85 Add newlines after closing braces. 2019-06-08 13:20:14 +02:00
Paul Chote
9f15754926 Remove scoped blocks in ReplayBrowserLogic. 2019-06-08 13:20:14 +02:00
Paul Chote
208b5b9686 Enable StyleCop rule SA1129. 2019-06-08 13:19:57 +02:00
Paul Chote
ebd36891dc Switch other struct types to default(T). 2019-06-08 13:19:57 +02:00
Paul Chote
dba1301b61 Change new BitSet<T> to default(BitSet<T>). 2019-06-08 13:19:57 +02:00
Paul Chote
37889af20e Enable StyleCop rule SX1101 2019-06-08 13:19:27 +02:00
Paul Chote
dabc7ec8dd Remove unnecessary this. references. 2019-06-08 13:19:27 +02:00
Paul Chote
ebe37a44ad Require force move for all undeploy-triggering orders. 2019-06-08 02:09:30 +02:00
Paul Chote
5d886b79f1 Remove AlternateTransportsMode.
This conflicts with undeploy orders and has been largely
superseded by queued enter orders.
2019-06-08 02:09:30 +02:00
Paul Chote
ecd8dee575 Add TransformsInto* traits to trigger construction yard undeploy. 2019-06-08 02:09:30 +02:00
Paul Chote
1b026b7e20 Disable out-of-range non-force targeting for deployed units. 2019-06-08 02:09:30 +02:00
Paul Chote
c853e8c5d6 Disable non-force move for deployed units. 2019-06-08 02:09:30 +02:00
tovl
ea036d4cc0 Allow move orders to cancel DeployForGrantedCondition. 2019-06-08 02:09:30 +02:00
reaperrr
8589e26dc2 Resolve rally point target on first run. 2019-06-07 22:18:33 +01:00
reaperrr
e6402d28a3 Fix and streamline MaximumPitch values in TS
The internal default is way too low for TS aircraft
(especially when passing cliffs).
2019-06-07 22:18:33 +01:00
reaperrr
52ef5617d3 Clarify MaximumPitch and AltitudeVelocity descriptions
AltitudeVelocity is strictly only for vertical-only movement,
MaximumPitch is only for altitude changes during horizontal movement.
2019-06-07 22:18:33 +01:00
reaperrr
ac08f24828 Make aircraft move to CruiseAltitude on new order 2019-06-07 22:18:33 +01:00
reaperrr
ce3d7c98ad Refactor TakeOff
- Make it self-contained by moving actual take-off
  from 'Fly' to this
- Make 'moveToRallyPoint' a simple boolean
- Make AttackMove to rally point a child activity
- Make TakeOff uninterruptible
2019-06-07 22:18:33 +01:00
reaperrr
4f8f8cfb9d Merge HeliFly into Fly 2019-06-07 22:18:33 +01:00
reaperrr
5698ea0910 Remove HeliFlyAndLandWhenIdle
Already obsolete, as aircraft with CanHover do properly become idle
and land when LandOnIdle is set to 'true'.
They currently need VTOL too, but all CanHover-aircraft
in the shipping mods have that and it will be fixed soon as well.
2019-06-07 22:18:33 +01:00
abcdefg30
27cfa9b1f0 Fix MAD tanks always being repairable 2019-06-06 00:48:50 +02:00
abcdefg30
bf6fa94224 Remove unnecessary comments from aircraft.yaml 2019-06-05 00:54:55 +02:00
abcdefg30
26ec5946b3 Add LandableTerrainTypes to D2k's frigate 2019-06-05 00:54:55 +02:00
abcdefg30
1a078d13aa Remove the Ore landable terrain type from TRAN in TD 2019-06-05 00:54:55 +02:00
abcdefg30
c10f4e53e0 Work around C17s not being able to deliver units 2019-06-05 00:54:55 +02:00
Paul Chote
760a2b483e Fix RA/TD map editor copy/paste tile definitions. 2019-06-02 16:09:12 +02:00
Mustafa Alperen Seki
ccc68b0272 Make Crate trait public. 2019-06-02 15:34:06 +02:00
Paul Chote
229bac6777 Disable capturing while the make animation is playing. 2019-06-02 15:26:26 +02:00
reaperrr
3ff8fb3cd2 Rename Hovers' OffsetModifier to BobDistance 2019-06-02 10:00:58 +01:00
reaperrr
2f1f0c8aec Adapt TS aircraft to changed Hovers defaults 2019-06-02 10:00:58 +01:00
reaperrr
d5c66d9474 Fix or prevent bugs in Hovers
- Clamp fallTickHeight to at least 1,
  to avoid potential DivideByZero crash.
- Prevent modders from setting values that
  are bogus or would trigger other bugs,
  via loadtime YamlExceptions.
2019-06-02 10:00:58 +01:00
reaperrr
b60346abb1 Polish various aspects of Hovers
- Use WDist instead of int for fields
- Change default values to approximately restore previous
  releases' default behavior
- Improve and clarify descriptions
2019-06-02 10:00:58 +01:00
teinarss
4fae77ed1c Writing benchmark data at the end of the game 2019-06-02 00:00:48 +02:00
Ivaylo Draganov
982291119c Fix misaligned TD production tooltip icons 2019-06-01 08:52:59 +01:00
Paul Chote
1614cba99e Fix warhead removal lint warnings. 2019-05-31 20:55:38 +02:00
Paul Chote
fb075dc803 Improve linting of weapon and trait yaml removals. 2019-05-31 20:55:38 +02:00
ltem
2a7ea28b74 Fix inconsistency in oberserver statistics 2019-05-31 20:50:23 +02:00
abcdefg30
11e4c971c4 Fix a compiler error (wrong using) in D2kActorPreviewPlaceBuildingPreview 2019-05-31 16:36:19 +02:00
Evgeniy S
3a30b013a5 Move Selection into a Trait 2019-05-31 15:50:53 +02:00