Commit Graph

43 Commits

Author SHA1 Message Date
Taryn Hill
4ed53c5952 Simplify return statements.
Remove redundant ‘this’.
Remove unused using directives.
Simplify LINQ chains.
Add some trait property descriptions.
Add readonly where viable.
Add fullstops to some yaml descriptions.
2015-04-01 12:33:17 -05:00
Oliver Brakmann
6fca67e7f6 Merge pull request #7664 from penev92/bleed_harvesterInsurance
Implement Carryall edge spawn, harvester delivery by carryall and harvester insurance for D2k
2015-03-25 20:03:00 +01:00
abcdefg30
c5a5bb0844 Add a missing space in the Template description 2015-03-23 17:27:51 +01:00
penev92
efee3598f9 Add D2k harvester insurance on worm frenzy 2015-03-22 17:00:59 +02:00
penev92
0d05fb5326 Implement FreeActorWithDelivery to enable off-map harvester delivery
Fix FreeActorInfo fields descriptions
2015-03-22 17:00:57 +02:00
penev92
7608cb93b4 Split CarryUnit into PickupUnit and DeliverUnit 2015-03-22 16:58:15 +02:00
penev92
4eb67b328f Refactor AutoCarryall trait and rename to Carryall
Fixup Carryable
2015-03-22 16:58:14 +02:00
penev92
f9a2378be8 Produce D2k carryalls at the edge of the map 2015-03-22 16:58:13 +02:00
Matthias Mailänder
737a0e0b67 move common traits 2015-03-15 18:25:28 +01:00
Paul Chote
00a2146299 Adjust GetImage plumbing in preparation for race-specific sequences. 2015-03-02 20:46:24 +00:00
Paul Chote
e52c15553f Remove legacy sidebar code. 2015-02-20 16:46:55 +00:00
abcdefg30
f63bc1e001 Fix a glitch in WithBuildingPlacedOverlay
when transforming the actor.
2015-02-18 12:50:17 +01:00
huwpascoe
804cdee8f0 BugFix: harvester-carryall remote death
The d2k harvester would suddenly explode if the approaching carryall was
destroyed. This is because there was no distinction between the unit being
carried and the unit being reserved. To test you'll probably have to tweak
the turret missile in weapons.yaml so you can forcefire on the carryall.

* added a bool to check if carryall is actually holding it's target
* fixed harvester being stuck in reserved mode
2015-02-03 22:43:35 +00:00
RoosterDragon
82bea961ba Checked LINQ queries and collections for inefficiencies.
- Made Array.IndexOf available via extension method.
- Made ToHashSet extension method.
- Change collections queried often via Contains into sets.
- Avoid Count() extension if Count or Length property exist.
- Made Count() > 0 checks and variations calls to Any() instead.
- Don't call ToList/ToArray if there is no benefit to materializing the sequence.
- If the sequence does benefit from materialization, follow this general pattern:
  - Collection queried often via Contains use ToHashSet to speed up lookups.
  - Short lived variables use ToList. This is because ToArray requires an extra copy to output the final size.
  - Collections persisted into fields or for a long time use ToArray to minimize memory overhead.
2015-01-29 19:20:11 +00:00
penev92
a4a8a793df Add EnemyWatcher trait to D2k and AnnounceOnSeen to D2k units and sandworms; remove sandworm announcement on worm spawn 2015-01-17 14:41:23 +02:00
penev92
e6f1c6b460 Enhance sandworm targeting logic by having actors produce noise 2015-01-14 21:26:55 +02:00
reaperrr
0e1773ac5d Move Production to Mods.Common 2015-01-11 03:04:39 +01:00
abcdefg30
8ca61aa917 Updated all year numbers 2015-01-09 21:18:05 +01:00
RoosterDragon
a6cda967c2 Formatted all files.
Automatically formatted all files via VS. This generally corrects indentation, removes trailing whitespace and corrects misplaced tabs or spaces. Manually tweaked a few files where required.
2015-01-06 21:28:50 +00:00
Matthias Mailänder
bc3acfeee7 StyleCop clean OpenRA.Game 2015-01-04 15:38:54 +01:00
Matthias Mailänder
d2d715765c Merge pull request #7263 from reaperrr/ra-common26
Moved Armament, Attack, Move, Air features and dependencies to Mods.Common
2015-01-04 15:33:16 +01:00
reaperrr
cb3ba37462 StyleCop fixes 2015-01-04 15:02:19 +01:00
reaperrr
654f56c5d5 Moves Attack, Armament, Move, Air traits and activities as well as anything required by them to Mods.Common.
Extracts Exit from Production into its own trait.
2015-01-04 05:24:28 +01:00
Matthijs Benschop
3c49364b57 Fix harvesters doing nothing after being dropped of by a carryall 2015-01-03 22:44:41 +01:00
Matthijs Benschop
740595064a The carryable should not unreserve itself 2015-01-03 22:44:41 +01:00
Matthijs Benschop
0868558e94 Allow a carryable to change his destination after being reserved 2015-01-03 22:44:41 +01:00
Oliver Brakmann
ce41c60a40 Merge pull request #7244 from Hellhake/bom
Remove BOM
2015-01-02 12:11:27 +01:00
Hellhake
fa72e04042 Remove BOM 2015-01-01 22:51:12 +01:00
Matthias Mailänder
3835aec17f add an attack overlay for the sand worm 2015-01-01 14:53:04 +01:00
Paul Chote
df425b29b3 Merge pull request #7194 from reaperrr/move-ra-common25
More Mods.RA reorganisation, more files moved to Mods.Common
2015-01-01 16:39:26 +13:00
Oliver Brakmann
de0a62eb42 Add a lobby option to control spawning creeps (viceroids/worms)
The lobby option is only exposed in d2k currently, not in TD or TS.
2014-12-28 19:26:39 +01:00
reaperrr
9dfd369446 Move some Building traits and related elements to Mods.Common 2014-12-26 21:38:49 +01:00
reaperrr
2f67a88b93 Move Armament, Attack* and various other traits to Traits namespace 2014-12-26 21:38:48 +01:00
reaperrr
d58807cdb8 Dissolve RA.Buildings namespace.
Move a handfull related, loose traits to RA.Traits as well.
2014-12-26 21:38:46 +01:00
Paul Chote
2726108cff Fix d2k spacing and ordering style nits. 2014-12-26 12:13:09 +13:00
penev92
681042caec Further RA project cleanup 2014-12-23 15:18:07 +02:00
reaperrr
5c5210f5e3 Dissolve Move namespace into Activities & Traits 2014-12-22 17:32:08 +01:00
reaperrr
2d7c1a3394 Rename CommonTraitsInterfaces to TraitsInterfaces, move to Traits namespace 2014-12-19 13:18:36 +01:00
reaperrr
c19d096d92 Bring Mods.D2k in line with our new folder/namespace structure 2014-12-17 13:10:50 +01:00
penev92
09350528fd Moving renders
Remove Traits.Render
2014-12-09 01:29:25 +02:00
reaperrr
7470391c5d Move RA World traits, FrozenUnderFog Modifier and various other traits into Traits 2014-12-03 12:52:17 +01:00
reaperrr
aad6ad00a1 Adds description to ChooseBuildTabOnSelect 2014-11-23 18:13:35 +01:00
reaperrr
1a032d6f6c Reorganize Mods.D2k 2014-11-16 17:03:52 +01:00