Commit Graph

18225 Commits

Author SHA1 Message Date
RoosterDragon
bbdd597917 Merge pull request #9394 from pchote/unstatic-sound
Unstatic the Sound class.
2015-09-20 22:58:00 +01:00
Paul Chote
7f4663f606 Pull out a temporary variable in ProductionQueue. 2015-09-20 22:46:07 +01:00
Paul Chote
d112083c44 Clean up sound devices on game exit. 2015-09-20 22:46:07 +01:00
Paul Chote
ef55d646f7 Unstatic the Sound class. 2015-09-20 14:11:06 +01:00
Paul Chote
ff10fe3e07 Merge pull request #9377 from reaperrr/fix-bldplace-overlay
Fixed TS crane overlay's last frame hiding idle overlay
2015-09-20 12:13:52 +01:00
Paul Chote
141575fc45 Merge pull request #9339 from reaperrr/sbag-fence
Makes only concrete walls block fire
2015-09-20 11:57:04 +01:00
Pavel Penev
db11b81c13 Merge pull request #9371 from reaperrr/maketest-order
Changed make.ps1 test order
2015-09-20 03:15:53 +03:00
Matthias Mailänder
c79f5a20a5 Merge pull request #9369 from RoosterDragon/cross-thread-checks
Added thread-affinity checks to SDL2 renderer
2015-09-19 21:09:08 +02:00
reaperrr
5ec1f8f8a0 Merge pull request #9379 from atlimit8/DanglingActorInfoTraitsContains
Changed missed ActorInfo.Traits.Contains => ActorInfo.HasTraitInfo
2015-09-19 20:55:16 +02:00
reaperrr
4aaa62845d Fix TS repair depot idle overlay
This was an idle animation in the original, and this and "platform" cannot be displayed at the same time anyway.
Also increased Tick rate to match idle light.
2015-09-19 20:37:59 +02:00
reaperrr
58e474ec80 Make repair overlay invisible when not repairing 2015-09-19 20:37:58 +02:00
reaperrr
e99c951a0c Hide WithBuildingPlacedOverlay after it has been played
Fixes #9319.
2015-09-19 20:37:57 +02:00
Paul Chote
7dfd5ade3a Merge pull request #9301 from atlimit8/WDistTraitRangeFields
Make Range WDist for all traits with circular ranges.
2015-09-19 19:10:34 +01:00
Paul Chote
3fec4c2032 Merge pull request #9298 from atlimit8/AffectsShroud
Create abstract class AffectsShroud[Info] with RevealsShroud core logic also used by CreatesShroud
2015-09-19 18:46:23 +01:00
atlimit8
131084d129 Changed missed ActorInfo.Traits.Contains => ActorInfo.HasTraitInfo 2015-09-19 12:06:37 -05:00
atlimit8
de7f5a4288 Make Range WDist for all traits with circular ranges. 2015-09-19 11:02:28 -05:00
abcdefg30
97346e1833 Merge pull request #9355 from ChaoticMind/socket_crash
Catch exception when hosting server on busy port
2015-09-19 17:27:11 +02:00
abcdefg30
6cbcd66b87 Merge pull request #9215 from LipkeGu/upnp_externalip_fix
Move NAT Logic from ClientTooltipLogic into its own Function at LobbyUtils.
2015-09-19 17:22:02 +02:00
reaperrr
d77839bb3d Merge pull request #9332 from atlimit8/TraitInfoAccess_1
TraitInfo through ActorInfo and HasTrait Removal
2015-09-19 17:06:10 +02:00
atlimit8
09984683a7 Add ActorInfo.TraitInfo[OrDefault]<T>() requiring ITraitIfo types 2015-09-19 09:56:14 -05:00
atlimit8
6970959ef1 .Trait[OrDefault]<Trait> => .Info.Traits.Get[OrDefault]<TraitInfo> where applicable 2015-09-19 09:49:24 -05:00
atlimit8
8162fa27ab Add ActorInfo.HasTraitInfo<T>() requiring ITraitInfo types 2015-09-19 09:49:24 -05:00
atlimit8
85fab45451 Remove Actor.HasTrait<T>() 2015-09-19 09:49:23 -05:00
reaperrr
d62460cfa1 Reorder yaml testing in make.ps1 to match makefile 2015-09-19 14:28:20 +02:00
reaperrr
959914779f Merge pull request #9376 from pchote/fix-news-panel-width
Make the news panel dropdown consistent across mods.
2015-09-19 14:20:38 +02:00
Paul Chote
55dee63b55 Make the news panel dropdown consistent across mods. 2015-09-19 12:46:07 +01:00
Matthias Mailänder
c0dd9c4566 Merge pull request #9359 from RoosterDragon/fix-pathfinder-layer-pooling
Fixed pooling of layers used for pathfinding
2015-09-19 13:07:33 +02:00
Matthias Mailänder
b5a5dfdb54 Merge pull request #9365 from atlimit8/HealUnitsCrateAction_use_ActorsWithTrait
HealUnitsCrateAction.Activate() use ActorsWithTrait<Health>()
2015-09-19 12:53:25 +02:00
Matthias Mailänder
6c26251b41 Merge pull request #9368 from atlimit8/Harvester_linq_syntax
Replace only use of Linq syntax
2015-09-19 12:03:19 +02:00
RoosterDragon
fc436f1aab Added thread-affinity checks to SDL2 renderer.
If a call is made into a graphics resource that has thread-affinity, from a thread other than the one that created the graphics device, an exception will now be thrown to make debugging easier.
2015-09-18 21:04:21 +01:00
atlimit8
be010249d7 Replace only use of Linq syntax 2015-09-18 10:31:41 -05:00
atlimit8
1d9d28b540 HealUnitsCrateAction.Activate() use ActorsWithTrait<Health>() 2015-09-17 23:55:38 -05:00
reaperrr
4fa20e78fa Merge pull request #9304 from atlimit8/Fix_AttackBase_GetMinimumRange
Make AttackBase.GetMinimumRange() return WDist.Zero if there are no available armaments
2015-09-18 01:26:35 +02:00
reaperrr
ef451ad4a7 Merge pull request #9356 from atlimit8/RemoveIBodyOrientation
Remove redundant IBodyOrientation[Info] & replace with BodyOrientation[Info]
2015-09-18 01:11:54 +02:00
reaperrr
1c759427b5 Merge pull request #9358 from abcdefg30/ts_stnk
Fix a crash when the stnk of TS is cloaking
2015-09-18 01:05:18 +02:00
Kevin Azzam
f4461b292e Generalize error message when creating a server fails 2015-09-17 20:03:05 +02:00
RoosterDragon
519be4374c Fixed pooling of layers used for pathfinding.
The previous implementation:
- Was failing to dispose of pooled layers.
- Was using a finalizer to allow undisposed layers to be reused.

This means all pooled layers are kept alive indefinitely until the map changes. If the finalizer is slow for any reason then the pathfiinder will allocate new layers when the pool runs out. Since these new layers are eventually stuffed back into the pool when the finalizer does run, this can theoretically leak unbounded memory until the pool goes out of scope. In practice it would leak tens of megabytes.

The new implementation ensures layers are disposed and pooled correctly to allow proper memory reuse. It also introduces some safeguards against memory leaks:
- A cap is set on the number of pooled layers. If more concurrent layers are needed than this, then the excess layers will not be pooled but instead be allowed to be garbage collected.
- No finalizer. An implementation that fails to call dispose simply allows the layer to be garbage collected instead.
2015-09-16 21:25:46 +01:00
abcdefg30
a5b9442170 Fix a crash when the stnk of TS is cloaking 2015-09-16 17:54:06 +02:00
Kevin Azzam
89f2a479bf Catch exception when hosting server on busy port
Closes #9354
2015-09-16 13:08:23 +02:00
atlimit8
45112cfa76 Remove redundant IBodyOrientation[Info] & replace with BodyOrientation[Info] 2015-09-15 22:57:08 -05:00
reaperrr
886f366926 Clean up TS wall default
- don't give experience
- don't update player statistics
- don't count it as structure that must be destroyed
2015-09-16 00:51:44 +02:00
reaperrr
b5bf9ec605 Make TS sandbags not block fire anymore 2015-09-16 00:51:43 +02:00
reaperrr
81b8754ffa Make only concrete walls block fire in RA 2015-09-16 00:51:42 +02:00
reaperrr
42a4722ebc Make only concrete walls block fire in TD 2015-09-16 00:51:40 +02:00
Matthias Mailänder
59edf85513 Merge pull request #9344 from reaperrr/fix-ra-water
Fixed RotationPaletteEffect tileset validity check
2015-09-15 21:10:37 +02:00
Guido L
8a1a6945f1 Fix and move Logic into its own Function in LobbyUtils 2015-09-14 23:19:50 +02:00
reaperrr
6613db7a15 Fix RotationPaletteEffect tileset validity check
If Tilesets was empty but ExcludeTilesets was not, it would always return false even though that combination is supposed to mean only the excluded tileset(s) is/are not valid for this effect.
2015-09-14 16:36:56 +02:00
reaperrr
605ec81c55 Merge pull request #9203 from Mailaender/tunnel-rendering
Added tunnel top rendering
2015-09-14 15:42:14 +02:00
reaperrr
642497a5b7 Merge pull request #9323 from abcdefg30/d2k_rock
Fixed a wrong tileset definition in d2k
2015-09-14 15:17:09 +02:00
Pavel Penev
3fc41238d8 Merge pull request #9333 from atlimit8/DuplicateUnitCrateAction_EnabledTargetting
Make DuplicateUnitCrateAction only check enabled targetability
2015-09-14 02:45:19 +03:00