Files
OpenRA/OpenRA.Mods.Common/Traits
Oliver Brakmann 30cf8c204b Fix desync when removing smudges
The cause of the crash was that the `RemoveSmudge` method only invokes `SharedRandom` in the else-branch of an if condition that is only taken when the `RenderPlayer` has fog visibility on the location (locations the `RenderPlayer` can see get removed from `dirty` in `TickRender`).

To add insult to injury, the `Type` field does not even need to get set since we are only using the `Sprite` field's `null` value as a marker to be picked up by the `TickRender` method. The `Type` field is only ever used twice in `AddSmudge`, in a branch of an if-condition that will not be taken when the `Sprite` field is null, which we set explicitly. The same holds true for the `Depth` field.
2016-07-26 21:46:18 +02:00
..
2016-07-12 20:17:45 -03:00
2016-07-26 21:46:18 +02:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-06-21 21:38:19 +01:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-04-10 09:41:12 -04:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-06-25 16:29:47 +01:00
2016-02-21 16:30:48 +00:00
2016-06-18 11:37:57 +02:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-03-30 02:46:19 +02:00
2016-03-30 02:46:19 +02:00
2016-02-21 16:30:48 +00:00
2016-06-21 19:13:25 +02:00
2016-04-24 20:12:49 +02:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-03-28 16:15:44 -05:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-02-21 16:30:48 +00:00
2016-06-26 20:30:06 +02:00