Commit Graph

74 Commits

Author SHA1 Message Date
RoosterDragon
82bea961ba Checked LINQ queries and collections for inefficiencies.
- Made Array.IndexOf available via extension method.
- Made ToHashSet extension method.
- Change collections queried often via Contains into sets.
- Avoid Count() extension if Count or Length property exist.
- Made Count() > 0 checks and variations calls to Any() instead.
- Don't call ToList/ToArray if there is no benefit to materializing the sequence.
- If the sequence does benefit from materialization, follow this general pattern:
  - Collection queried often via Contains use ToHashSet to speed up lookups.
  - Short lived variables use ToList. This is because ToArray requires an extra copy to output the final size.
  - Collections persisted into fields or for a long time use ToArray to minimize memory overhead.
2015-01-29 19:20:11 +00:00
Matthias Mailänder
24deec2a7b fix CodeLineMustNotEndWithWhitespace 2015-01-25 18:41:29 +01:00
penev92
502ed6a0e7 Add SpriteHarvesterDockSequence and VoxelHarvesterDockSequence
Pass drag-related info from Refinery to HarvesterDockSequence
2015-01-25 17:17:34 +02:00
penev92
c18da7abb0 Fix harvester dock sequence names 2015-01-25 16:58:04 +02:00
penev92
202e280551 Fix OreRefinery and TiberiumRefinery names 2015-01-25 16:58:03 +02:00
penev92
6a40dfd0db Changed IAcceptOre to IAcceptResources 2015-01-25 16:58:02 +02:00
penev92
52cc69fd1f Move Crate, CrateSpawner and all CrateActions to Mods.Common 2015-01-18 16:40:55 +02:00
penev92
f1a0f6e2a5 Move Parachute, Parachutable and ParaDrop to Mods.Common 2015-01-18 16:15:14 +02:00
reaperrr
e8fbfc366a Moves some misc traits/activities to Mods.Common, moves some RA traits into the Traits folder 2015-01-15 13:18:12 +01:00
reaperrr
be9d37f30e Moves SupportPowers and related Widgets to Mods.Common 2015-01-15 13:18:11 +01:00
reaperrr
f897a9ff01 Moves Upgrades and Invulnerable trait to Mods.Common 2015-01-15 00:07:27 +01:00
abcdefg30
a4f051ad6b Added a lua function for paratroopers 2015-01-13 17:48:11 +01:00
reaperrr
c431545a44 Wrap up Render traits move 2015-01-11 03:04:42 +01:00
reaperrr
0e1773ac5d Move Production to Mods.Common 2015-01-11 03:04:39 +01:00
abcdefg30
8ca61aa917 Updated all year numbers 2015-01-09 21:18:05 +01:00
penev92
8504c233d9 Move everything Repair-related to Mods.Common 2015-01-08 01:49:14 +02:00
penev92
bcd5160604 Move everything Bridge-related to Mods.Common 2015-01-08 01:47:20 +02:00
RoosterDragon
a6cda967c2 Formatted all files.
Automatically formatted all files via VS. This generally corrects indentation, removes trailing whitespace and corrects misplaced tabs or spaces. Manually tweaked a few files where required.
2015-01-06 21:28:50 +00:00
reaperrr
573c26145e Move Render*Circle, ThrowsParticle and ParatroopersPower to appropriate locations 2015-01-04 18:12:11 +01:00
reaperrr
7a8826f5e0 Move Targetable*, Seeds/StoresResource(s) and two RenderBuilding traits to Mods.Common 2015-01-04 18:12:10 +01:00
reaperrr
d07db9c6a9 Move Guard, CashTrickler, Explodes, SelfHealing, Sellable and Crushable to Mods.Common.
Extract Guardable trait from Guard into own file.
2015-01-04 18:12:08 +01:00
Matthias Mailänder
1b0e3a7a7f StyleCop clean OpenRA.Mods.RA 2015-01-04 17:02:46 +01:00
Matthias Mailänder
bc3acfeee7 StyleCop clean OpenRA.Game 2015-01-04 15:38:54 +01:00
Matthias Mailänder
d2d715765c Merge pull request #7263 from reaperrr/ra-common26
Moved Armament, Attack, Move, Air features and dependencies to Mods.Common
2015-01-04 15:33:16 +01:00
Oliver Brakmann
4cdf1b73c4 Merge pull request #7167 from MatthijsBenschop/d2k-carryall-extras
Some carryall fixes
2015-01-04 14:11:13 +01:00
reaperrr
654f56c5d5 Moves Attack, Armament, Move, Air traits and activities as well as anything required by them to Mods.Common.
Extracts Exit from Production into its own trait.
2015-01-04 05:24:28 +01:00
Oliver Brakmann
158517c09f Merge pull request #7251 from Mailaender/stylecop-clean-game
StyleCop cleaned OpenRA.Game Part 1
2015-01-04 01:00:56 +01:00
reaperrr
eb33d72a70 Merge pull request #7254 from penev92/bleed_moveFiles
Moving more files to Common
2015-01-04 00:46:11 +01:00
Matthijs Benschop
3c49364b57 Fix harvesters doing nothing after being dropped of by a carryall 2015-01-03 22:44:41 +01:00
RoosterDragon
c7b4eff89a Ensure the whole path search cache is initialized.
The region covered by map.Cells may not cover the whole map size, but we need the whole cache initialized so it can be used correctly when a different map is used, because that map may have the same size but a different offset which means a different region is covered.
2015-01-03 20:07:04 +00:00
Matthias Mailänder
44cd174a8d StyleCop clean OpenRA.Game 2015-01-03 19:00:48 +01:00
penev92
62601491ad Move Enter and Repair Building activities, EngineerRepair trait and ActorExts to Mods.Common and extract IgnoresDisguise trait to its own file 2015-01-03 07:03:41 +02:00
penev92
5e1af58bbe Move Gives/Gains Experience and Bounty to Mods.Common 2015-01-03 07:03:28 +02:00
penev92
04c09dda31 Add a delay before wandering, use it on viceroids
Add a Min and Max delay and make it random
2015-01-03 06:56:20 +02:00
penev92
ded8ae9345 Add Wanders trait and make AttackWander inherit that 2015-01-03 06:52:49 +02:00
Matthias Mailänder
9dd607c846 Merge pull request #7230 from RoosterDragon/occupied-cells-arrays
Make OccupiedCells implementations return arrays.
2015-01-02 17:38:56 +01:00
Matthias Mailänder
167ba72119 Merge pull request #7246 from Hellhake/stylecop-ra
Fix StyleCop warnings in OpenRA.Mods.RA
2015-01-02 16:38:22 +01:00
Hellhake
b6410bc1e0 Fix StyleCop warnings in OpenRA.Mods.RA 2015-01-02 14:39:49 +01:00
Hellhake
fa72e04042 Remove BOM 2015-01-01 22:51:12 +01:00
RoosterDragon
fe24304a21 Make OccupiedCells implementations return arrays.
Since there are only one or two items, it's cheaper to return a concrete collection and avoid the overhead of the compiler generated state machine.

This in particular speeds up Shroud.GetVisOrigins when dealing with Mobile.OccupiedCells, as the expensive CanEnterCell call is made only once rather than twice.
2014-12-30 17:25:04 +00:00
reaperrr
311e347ad2 Style fixes 2014-12-26 22:10:52 +01:00
reaperrr
9dfd369446 Move some Building traits and related elements to Mods.Common 2014-12-26 21:38:49 +01:00
reaperrr
2054e41552 Dissolve Render namespace 2014-12-26 21:38:47 +01:00
reaperrr
d58807cdb8 Dissolve RA.Buildings namespace.
Move a handfull related, loose traits to RA.Traits as well.
2014-12-26 21:38:46 +01:00
penev92
681042caec Further RA project cleanup 2014-12-23 15:18:07 +02:00
reaperrr
370c3c65b6 Moved AttackLeap to Mods.RA.Traits, moved AttackPopupTurreted to
Mods.Cnc.Traits
2014-12-22 18:13:30 +01:00
reaperrr
65a140afa5 Dissolve Crates namespace, move CrateActions and Crate trait to Traits/Crates 2014-12-22 18:13:29 +01:00
reaperrr
52219b1c7a Dissolve Infiltration namespace 2014-12-22 18:13:28 +01:00
reaperrr
5c5210f5e3 Dissolve Move namespace into Activities & Traits 2014-12-22 17:32:08 +01:00
RoosterDragon
c37a691c33 Convert some keys users of CellLayer to index via map-coords for efficiency. 2014-12-20 23:39:03 +00:00